-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin: Yesterday's note #5159
Conversation
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2]:You should not cast this, instead use a Do NOT open a new PR for re-validation. |
I've refactored the code to use the |
Changes requested by bot have been made, ready for additional review by human. |
"fundingUrl": "https://trevortylerlee.com", return await this.app.vault.read(templateFile); const leaf = this.app.workspace.getUnpinnedLeaf(); Is there an expected use case for the Daily Note settings and your plugin's settings to differ? For example, for the Daily Note's date format and your plugin's date format setting to be different? I would recommend either removing settings from your plugin that can be inherited from the Daily Notes plugin settings, or adding a description to each setting that defaults to the Daily Note plugin settings to make it clear that it will inherit the Daily Note plugin setting, and that the user does not need to fill out that setting. |
Thanks for the feedback, made the following changes:
|
Changes requested by Zachatoo have been made, assigning additional human for additional review |
Please remove the "Obsidian" branding from the image in your README, that makes it look like this is an official product. |
Done. |
@joethei Changes have been made, can you take another look? |
Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates. |
@joethei Bump |
Hello!I found the following issues in your plugin submission Errors: ❌ Your latest Release is missing the This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ Could not parse This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ Your latest Release is missing the This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
@joethei can I get some help? Not sure why it's saying my latest release is missing the |
@trevortylerlee The bot is correct, you are missing the main.js and manifest.json files from your latest release. Notice the difference between these two releases. If you use the GitHub action in your repo for releases then the step of adding those files to your release will be done for you. |
The automated review has not found any issues with your code, ready for manual review. |
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/trevortylerlee/yesterdays-note
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.